Add _pixelbuf support #42
Conversation
.pylintrc
Outdated
| @@ -18,6 +18,7 @@ ignore-patterns= | |||
| #init-hook= | |||
|
|
|||
| # Use multiple processes to speed up Pylint. | |||
| # jobs=1 | |||
There was a problem hiding this comment.
Looks like there is a bunch of commented out changes; just make sure to remove them before you're done.
|
@rhooper Since pypixelbuf and the API changes were both merged, is this no longer WIP and ready to merge? I took a look and it's good from what I can tell but it may be wise to have someone more familiar with the code. In the meanwhile I'll do some testing |
|
This is no longer a wip |
|
Before someone else merges, might be worth mentioning this issue in the NeoPixel repo that popped up: |
| @@ -15,7 +15,7 @@ | |||
| 'sphinx.ext.viewcode', | |||
| ] | |||
|
|
|||
| # autodoc_mock_imports = ["digitalio", "busio"] | |||
| autodoc_mock_imports = ["pypixelbuf"] | |||
There was a problem hiding this comment.
Is this needed? Can't the real version be installed from pypi?
| `Feather M4 Express <https://www.adafruit.com/product/3857>`_ and | ||
| `DotStar FeatherWing <https://www.adafruit.com/product/3449>`_. | ||
|
|
||
| .. code-block:: python |
There was a problem hiding this comment.
I think this example would be better to have in a separate example file. The example in the readme should be short and simple. Other examples can do fancier things.
No description provided.